Skip to content

remove getImmutableFieldChanges references from hooks#129

Merged
ack-prow[bot] merged 1 commit intoaws-controllers-k8s:mainfrom
rushmash91:cel-immutability
Feb 19, 2025
Merged

remove getImmutableFieldChanges references from hooks#129
ack-prow[bot] merged 1 commit intoaws-controllers-k8s:mainfrom
rushmash91:cel-immutability

Conversation

@rushmash91
Copy link
Contributor

@rushmash91 rushmash91 commented Feb 18, 2025

fix aws-controllers-k8s/code-generator#565

Description of changes:
Remove getImmutableFieldChanges from hooks to support cel immutability

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and michaelhtm February 18, 2025 19:08
@ack-prow ack-prow bot added the approved label Feb 18, 2025
@rushmash91 rushmash91 mentioned this pull request Feb 18, 2025
Merged
@rushmash91 rushmash91 force-pushed the cel-immutability branch 2 times, most recently from 05342e6 to bd557dd Compare February 18, 2025 21:42
@rushmash91
Copy link
Contributor Author

rushmash91 commented Feb 18, 2025 •
edited
Loading

field URL immutability test for resource OpenIdConnectProvider removed

@ack-prow
Copy link

ack-prow bot commented Feb 18, 2025

@rushmash91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
iam-verify-attribution efe305c link false /test iam-verify-attribution

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelhtm
Copy link
Member

michaelhtm commented Feb 19, 2025

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
@ack-prow
Copy link

ack-prow bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit cee1aad into aws-controllers-k8s:main Feb 19, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlbutler jlbutler Awaiting requested review from jlbutler

@michaelhtm michaelhtm Awaiting requested review from michaelhtm

Assignees

@michaelhtm michaelhtm

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rushmash91 @michaelhtm